rusackas commented on PR #42919: URL: https://github.com/apache/superset/pull/42919#issuecomment-5719769696
@waterWang the SAVEPOINT approach is the right fix for the session poisoning, but @sadpandajoe caught some legit gaps in the recovery path that are still open, most recently the failure path dropping pre-existing tag associations. Want to see those addressed before this merges. Also needs a rebase on `master`, and pre-commit's failing (ruff-format wants a reformat). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
