rusackas commented on PR #37396: URL: https://github.com/apache/superset/pull/37396#issuecomment-5719730974
Heya @semohr, appreciate you sticking with this one so long. Couple of things before this can merge, though. `useGridColumns` now sets `headerName` straight from `collabels?.[originalIndex]` with no fallback to the column key, so if labels are ever missing or misaligned we're back to blank headers, exactly what codeant flagged and that thread's still open. There's also a good number of other unresolved threads mixing real feedback and bot noise, worth a pass to close out before we look at merging. Failing checks aren't on you: CodeQL's fighting a config version mismatch and postgres-hive hit a docker port collision, both infra noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
