mikebridge opened a new pull request, #44398: URL: https://github.com/apache/superset/pull/44398
### SUMMARY The Datasources list renders Semantic View as plain text while Physical and Virtual use icon badges. Route every Type cell through the shared DatasetTypeLabel, retaining the page's “Semantic View” wording through an optional label prop. Other consumers retain their existing default labels. Use the theme text color for the semantic badge foreground and icon, keeping the existing info background readable in light and dark themes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: plain “Semantic View” text. After: the shared info badge with apartment icon and the same text. No live-browser screenshot captured. ### TESTING INSTRUCTIONS With semantic layers enabled, open the Datasources list with semantic, physical and virtual rows; confirm all Type cells have badges and the semantic row retains “Semantic View”. Check light/dark themes. With semantic layers disabled, verify normal Physical/Virtual badges remain unchanged. Automated: 17 focused tests across DatasetTypeLabel and DatasetList pass, covering mixed rows, flag-off behavior, default/custom labels, icon and light/dark contrast. The original renderer fails the mixed-row regression. All required scoped pre-commit hooks, including frontend Type-Checking, pass with candidate-local dependencies and generated declarations. No backend/API or flag-default change. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SC-121075](https://app.shortcut.com/preset/story/121075) - [x] Required feature flags: existing SEMANTIC_LAYERS to show semantic rows - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
