bito-code-review[bot] commented on code in PR #40679:
URL: https://github.com/apache/superset/pull/40679#discussion_r4041127073
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -109,6 +109,10 @@ export interface SliceHeaderControlsProps {
description: string;
viz_type: string;
slice_name: string;
+ // The name as rendered in the header: the localized value, or the panel's
+ // own title override. Used for strings the viewer reads; slice_name stays
+ // the canonical value for edits, filenames and extension payloads.
+ display_name?: string;
Review Comment:
<!-- Bito Reply -->
The decision to leave the duplication in place is reasonable, as it avoids
unnecessary changes to a shared dashboard component. The explanation regarding
why the type mismatch did not cause runtime issues—specifically that the
variable usage bypasses TypeScript's excess-property check—is correct and
accurately describes the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
