rusackas commented on PR #44402: URL: https://github.com/apache/superset/pull/44402#issuecomment-5722515743
Heya @eschutho, small world. I hit this same root cause independently and opened #44406 before seeing this one. Converged on your access-scope idea (can_read/Annotation, can_access_datasource, reusing the referenced chart's own cache key) over the plain user_id + RLS-clause key I started with, credited over there. Main difference: this keeps the dataframe and annotation payload on one combined entry re-scoped by access class, mine splits them so the dataframe stays one shared entry regardless of how many access classes view the chart. We're touching the same file and test suite too, so whichever lands second needs a rebase. Should we reconcile onto one of these before either merges? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
