bito-code-review[bot] commented on PR #44414:
URL: https://github.com/apache/superset/pull/44414#issuecomment-5725729327
<!-- Bito Reply -->
The flagged issue is correct. The current implementation of
`processCloneForVisibility` in
`superset-frontend/src/utils/downloadAsImage.tsx` unconditionally sets
`overflow` to `visible` for all scrollable elements, which causes elements
relying on hidden overflow (like ellipsis in chart headers) to bleed outside
their containers during dashboard exports.
The fix implemented in the PR (which you can see in the diff) introduces a
`clipsOverflow` check and conditionally applies `overflowX: 'clip'` and
`overflowY: 'visible'` when `clipHorizontalOverflow` is true (used for
dashboard captures). This ensures vertical content is fully captured while
maintaining horizontal clipping to prevent layout bleeding.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/utils/downloadAsImage.tsx**
```
const clipsOverflow = (element: HTMLElement) => {
const computed = window.getComputedStyle(element);
return /auto|hidden|clip/.test(
`${computed.overflow} ${computed.overflowX} ${computed.overflowY}`,
);
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
