bito-code-review[bot] commented on PR #44366: URL: https://github.com/apache/superset/pull/44366#issuecomment-5733098304
<!-- Bito Reply --> The current tests in `useFilterOperations.test.ts` verify the logic for cleaning up stale dependencies in the dependency map, but they do not cover the UI rendering behavior in `FiltersConfigModal`. Adding a test case to `FiltersConfigModal.test.tsx` to simulate opening a saved filter with a cascade parent is a valid approach to ensure the dependency control and parent filter appear correctly upon initial render. If the component's mount-effect rerender makes this state transition unobservable in a test environment, documenting that as a test exemption is an appropriate alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
