eschutho commented on PR #44404: URL: https://github.com/apache/superset/pull/44404#issuecomment-5733131800
@richardfogaca routing this one your way. You reviewed and approved #44204, which added the `except json.JSONDecodeError:` in `_validate_report_extra` that this PR widens to `except (json.JSONDecodeError, TypeError):` — so you already have the context on this exact block. One behavioral change to ratify (PR is agent-assisted): a non-string `extra.dashboard.anchor` (e.g. int `42`, or a string like `"42"` that `json.loads` parses to a non-iterable) now surfaces as a **422 ValidationError instead of an unhandled 500** — bringing the validate-time path in line with the `execute.py` sibling that already catches both. No other behavior change; a regression test that fails on the pre-fix code is included, and CI is green. You're carrying a few reviews already — glad to re-route if you'd rather pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
