piyushraj001 commented on PR #44357: URL: https://github.com/apache/superset/pull/44357#issuecomment-5735415848
Thanks @gabotorresruiz for the detailed review and for verifying it manually! Added the regression test to both Select.test.tsx and AsyncSelect.test.tsx as suggested — it pins the DOM contract by asserting no .ant-space wrapper and that the first child is a text node. Also cleaned up the stray empty lines in the import blocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
