mikebridge commented on PR #43887: URL: https://github.com/apache/superset/pull/43887#issuecomment-5735483910
Merged master and addressed the review follow-ups in [883bd4a7f5](https://github.com/apache/superset/commit/883bd4a7f514a4790d620d6861db26cc4a64489a). @richardfogaca, following up on [your review](https://github.com/apache/superset/pull/43887#pullrequestreview-5251212033): - The upload-capability lookup now requires Database read, handles failed requests, and ignores stale responses. Regression tests prove layer-only users make no unauthorized Database request while supported uploads remain available to authorized users. - `protect_read` now documents that Public admission is checked per resource name: public Dataset read can admit anonymous callers to `/api/v1/datasource/`, while each source's permissions and row filters still apply. - Added coverage for legacy Datasource-only grants (403 with the semantic-layer flag on or off) and Database/SemanticLayer read grants supplied by two separate roles using real FAB permission aggregation. Also adopted Bito's model-dispatched query mock and preserved the earlier action/export/endpoint fixes and the `has_access` public-grant behavior. Validation: 155 backend tests and 18 frontend tests passed in both owner and independent review; two owner public-access probes passed. MyPy, pylint and applicable lint/format hooks passed. The standard frontend hook could not run cleanly without built workspace declarations (TS6305); independent review's source-resolved type check passed with no diagnostics. Independent review approved the exact published tree with zero findings. New-head CI remains the post-push gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
