mikebridge commented on PR #44416: URL: https://github.com/apache/superset/pull/44416#issuecomment-5736406286
@richardfogaca @aminghadersohi — immediate follow-up opened: #44432, addressing [Richard's September 18, 18:21 UTC review](https://github.com/apache/superset/pull/44416#pullrequestreview-5251162269). [0eb74a1490](https://github.com/apache/superset/commit/0eb74a14905b1987289df59cf781281fd71cd914) reads the persisted datasource id in both denial builders. Real Gamma chart create/update and Explore form_data regressions now return 403 without touching the failing provider. Validation: 113 HTTP tests, 262 unit tests, required hooks, and independent review with zero findings. The follow-up body explicitly defers the flag-off save asymmetry and states that query-context type/id binding is checked on create and query-context-only update, not full PUT. Please review #44432; GitHub denied this account's formal reviewer-request permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
