bito-code-review[bot] commented on code in PR #44250: URL: https://github.com/apache/superset/pull/44250#discussion_r4054153241
########## docs/admin_docs/installation/docker-builds.mdx: ########## @@ -46,12 +51,14 @@ Here are the build presets that are exposed through the `supersetbot docker` uti - `dev`: For development, with a headless browser, dev-related utilities and root access. This includes some commonly used database drivers like `mysqlclient`, `psycopg2-binary` and some other used for development/CI -- `py311`, e.g., Py311: Similar to lean but with a different Python version (in this example, 3.11). -- `ci`: For certain CI workloads. -- `websocket`: For Superset clusters supporting advanced features. -- `dockerize`: Used by Helm in initContainers to wait for database dependencies to be available. +- `py311` and `py312`: Similar to lean but with a different Python version. -The `ci` and `showtime` Docker targets share an entrypoint that runs container +Standalone `websocket` and `dockerize` images are not published. The realtime +WebSocket server is bundled in the `superset`, `lean`, and `dev` images and can +be started with `/app/docker/entrypoints/run-websocket.sh`. Helm init containers +use the main Superset image for dependency checks. + +The unpublished `ci` and `showtime` Docker targets share an entrypoint that runs container Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Contradictory publish claim</b></div> <div id="fix"> Line 61 calls the `showtime` target "unpublished", but lines 22-23 say Showtime environments "publish images tagged like `pr-5252-a1b2c3d-ci`", and line 79 lists that tag under the Docker Hub key-tag examples. `showtime-trigger.yml` passes Docker Hub credentials to its sync step, so readers cannot tell where these images live. Scope the "unpublished" claim to the standard build workflow. </div> </div> <small><i>Code Review Run #9b6078</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
