hainenber opened a new pull request, #44459: URL: https://github.com/apache/superset/pull/44459
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> fix(build): resolve custom build inputs not passed to Webpack configs ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Notable agendas: - Resolves issue where custom build configs like `--measure=true` to activate Speed Measure Webpack plugin couldn't work as previously due to newer `webpack-cli`. - Remove `yargs` as direct dependency used in build process and use `node:utils.parseArgs` as native alternative. No changes to dep count or making `yargs` dev dep, unfortunately, but I hope this is the right thing to go forward. - Change the `--env superset=<url>` to more meaningful `--env supersetUrl` along with corresponding doc update. Reviewer's note: This is easier to review once you understand that the Webpack config is now wrapped in a function `(env, arg) => {}` to allow getting additional env vars and built-in args without using `yargs`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before <img width="712" height="121" alt="image" src="https://github.com/user-attachments/assets/b36e0c92-2e33-4b18-9c21-8bbdd7fc2a85"; /> After (added a console.log to indicate `measure`) <img width="712" height="121" alt="image" src="https://github.com/user-attachments/assets/fc45c263-6bf3-4715-978a-b4c5771dcbfd"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Check out the branch 2. Run `npm run dev-server` and/ or `npm run build` with additional Superset-specific CLI args. 3. Observe that there are no regressions ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
