bito-code-review[bot] commented on code in PR #44036:
URL: https://github.com/apache/superset/pull/44036#discussion_r4057533195
##########
superset/commands/database/utils.py:
##########
@@ -135,6 +135,53 @@ def ssh_tunnel_rebind_unsafe(
return not has_fresh_credential or stale_private_key_password
+OAUTH2_ENDPOINT_FIELDS = (
+ "authorization_request_uri",
+ "token_request_uri",
+ "redirect_uri",
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to limit the rebind check to `token_request_uri`
is appropriate. Since `redirect_uri` is a parameter in the token request body
rather than a destination for the client secret, treating its modification as
an unsafe rebind is overly restrictive and would cause false positives for
legitimate configuration changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
