codeant-ai-for-open-source[bot] commented on code in PR #44336: URL: https://github.com/apache/superset/pull/44336#discussion_r4058345741
########## UPDATING.md: ########## @@ -24,11 +24,20 @@ assists people when migrating to a new version. ## Next -- With `SEMANTIC_LAYERS` enabled, combined connection discovery honors `Database.can_read` and `SemanticLayer.can_read` independently. Each permitted source retains its normal row filters, including dynamic database filters for Admin. A source filter never includes rows or counts from a denied source; callers with neither read permission are denied. Feature-off database browsing is unchanged. -- The combined datasource list (`GET /api/v1/datasource/`) accepts Dataset read without an additional Datasource read grant, regardless of `SEMANTIC_LAYERS`. With the flag enabled, SemanticView read independently permits semantic-view discovery. Existing row-level dataset/chart access remains enforced. -- The `presto` extra requires PyHive 0.7.0 or later. PyHive 0.6.5 cannot load - its Presto dialect under SQLAlchemy 2 because it imports `sqlalchemy.databases`. - Upgrade existing installations with `pip install "pyhive[presto]>=0.7.0"`. +### Scheduled report and alert retry admission + +Run `superset db upgrade` before starting workers with this version. The migration +adds nullable `execution_owner` and `execution_window` columns to `report_schedule`. +Pause scheduling and drain in-flight executions and queued retry tasks before +upgrading workers together: older workers do not participate in execution fencing. +Retries queued by the old task signature are discarded rather than replayed without +ownership evidence. Restart scheduling after migration and worker replacement. Review Comment: **Suggestion:** Legacy retry tasks containing only the schedule ID are treated as fresh executions, so they are not reliably discarded and may replay after the stale-window threshold. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Comment mismatch` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4a8805c0bb7d46b1af58ef6b1cf9c533&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4a8805c0bb7d46b1af58ef6b1cf9c533&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** UPDATING.md **Line:** 33:34 **Comment:** *Comment Mismatch: Legacy retry tasks containing only the schedule ID are treated as fresh executions, so they are not reliably discarded and may replay after the stale-window threshold. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44336&comment_hash=62f0f26e59ff1b21ec3a9e42b82952dff2279bf62711cc10331e0ea256ffa223&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44336&comment_hash=62f0f26e59ff1b21ec3a9e42b82952dff2279bf62711cc10331e0ea256ffa223&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
