bito-code-review[bot] commented on PR #44469:
URL: https://github.com/apache/superset/pull/44469#issuecomment-5754634956
<!-- Bito Reply -->
The issue is correct. The `transformSeries` function now assigns
`labelLayout` to bar series with shown values to handle label legibility, which
causes the existing test to fail because it expects `labelLayout` to be
`undefined` for manual label placements. To resolve this, the test must be
updated to expect a function for `labelLayout` and verify that it correctly
applies the legibility floor (hiding labels for small segments) without
altering the manual position.
**superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformers.test.ts**
```
// Manual placements don't get the fit-aware Auto callback: their layout
// callback only applies the legibility floor and never repositions.
expect(result.label).toMatchObject({ position: expected });
const { labelLayout } = result;
expect(typeof labelLayout).toBe('function');
if (typeof labelLayout !== 'function') return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
