fitzee commented on code in PR #44336:
URL: https://github.com/apache/superset/pull/44336#discussion_r4061669089
##########
superset/commands/report/execute.py:
##########
@@ -1687,7 +1877,7 @@ def _handle_retry_or_error(
# send the retry-failure notification *after* the attempt ran so
# the email reflects what happened, not what is about to be
# scheduled. ("You will receive an update after each retry.")
- if current_attempt > 0:
+ if 0 < current_attempt < max_attempts:
Review Comment:
Fixed in 42ef0e73d09e8bb84f666117eead56c06bbf1685. The final per-attempt
notice is suppressed only when `send_failed_reports` supplies a replacement
final notice. Opted-in recipients therefore still receive a failure notice when
that setting is off. Tests exercise `ReportNotTriggeredErrorState.next()` for
both alerts and reports, with one retry and both values of
`send_failed_reports`, and verify no further retry is queued.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
