williaster commented on issue #8648: Prettify the frontend code URL: https://github.com/apache/incubator-superset/pull/8648#issuecomment-559144858 I plus one the single quote style On Tue, Nov 26, 2019, 6:40 PM Krist Wongsuphasawat <[email protected]> wrote: > I personally prefer single quote. All @superset-ui repos (superset-ui, > superset-ui-plugins, superset-ui-plugins-deckgl, superset-ui-template, > ...) currently use single quote, which would be great to keep same > consistency. It would also help Airbnb developers as Airbnb style guide > prefers single quote and our internal repos all use that. > > All @superset-ui repos share same build configuration (via beemo) with > the following prettier overrides. > > https://github.com/apache-superset/build-config/blob/master/configs/prettier.js > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-superset/pull/8648?email_source=notifications&email_token=ABCJZCIOBMBUSATJAR3PQDLQVXMY3A5CNFSM4JRNIRBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIC3MY#issuecomment-558902707>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABCJZCNRRCENPENZ5ZR3YYLQVXMY3ANCNFSM4JRNIRBA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
