[GitHub] [incubator-superset] villebro opened a new pull request #8678: Area na

[GitBox]

villebro opened a new pull request #8678: Area na
URL: https://github.com/apache/incubator-superset/pull/8678
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Area chart currently fails to render properly if there are missing groupby 
values in the time series. This PR makes it possible to specify NULL handling 
behavior per NVD3 chart, and defaults values to zero for the Area chart. Note: 
other charts are left unchanged, as defaulting to zero is most likely *not* 
expected behavior for all charts (at least line charts).
   
   ### BEFORE
   <img width="780" alt="Screenshot 2019-11-27 at 18 21 59" 
src="https://user-images.githubusercontent.com/33317356/69741686-2be38200-1144-11ea-8131-2646ae9bf4c6.png";>
   
   ### AFTER
   <img width="778" alt="Screenshot 2019-11-27 at 18 21 18" 
src="https://user-images.githubusercontent.com/33317356/69741705-3140cc80-1144-11ea-8806-e7135f32a42f.png";>
   
   ### TEST PLAN
   Visual inspection.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: closes #8671
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org