I3eka commented on PR #43136: URL: https://github.com/apache/superset/pull/43136#issuecomment-5758934605
@sadpandajoe, the two compatibility issues from your latest review are fixed at `ddaaed36f4`: worker mode uses the moved coordination backend, and the current-master merge has one migration head. Both regressions failed before the fixes and pass afterward. Validation: 698 AI tests plus the migration-graph test, 52 frontend tests, and pre-commit across all 113 PR files pass. The description has the exact scope and test limitations; fresh GitHub CI still needs to finish. The search change itself is unchanged. I am keeping the retention and knowledge-provider threads open: those contracts are still unwired here. The empty-tab render loop is a separate confirmed issue and will be kept out of this search PR. Existing focused fixes #44473 (feedback), #44493 (model pin) and #44497 (cancel/run ownership) are also not inherited by this branch yet. I rechecked the overview-only bot findings too. The object-wrapped-suggestions test failure is a false positive. Provider cleanup and duplicate SQL labels reproduce; retry wiring, raw page-context storage and run replay handling still need shared fixes. For the chart-metadata claim, the normal dashboard API also returns member charts after dashboard authorization, so I have not treated a missing standalone chart gate as proof of a permission bypass. `hold:sip!` stays untouched. No deployment, database migration, or request to bypass #42805/SIP-224 is included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
