I3eka commented on PR #43132: URL: https://github.com/apache/superset/pull/43132#issuecomment-5759850077
@sadpandajoe @villebro, I've reread all 18 review threads, including the resolved ones and later follow-ups, and checked them against this branch. Two concrete blockers are addressed: de098438f1 fixes the worker backend import and the probe that was disguising that import error as an unavailable Redis server; 53023e9095 merges Apache master `fc016454fb` and joins the migration heads without changing old revisions or force-pushing. The four constructor/probe regressions fail before the fix and pass afterwards. The selected-database dialect regression also passes again, including conflicting model-supplied engines. Local results: **703 backend tests, 2 isolated probe tests, 143 frontend tests**, and all applicable checks over the 113 PR files pass. Probe writes are mocked; I am not claiming a live Redis/Celery or deployment test. The new CI run is still pending. The SIP hold stays. I have linked the separate cancellation/run-binding and empty-chat fixes in their threads, without resolving findings that are not yet inherited. Idempotency, checkpoint isolation, worker-loss/expiry, context-size limits, setup and unopened-thread confirmation still need the shared-base follow-up. This refresh fixes the import/migration blockers, not those remaining contracts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
