I3eka commented on PR #43278: URL: https://github.com/apache/superset/pull/43278#issuecomment-5756278857
@justinpark, could you take another look at this SQL Lab fix, or suggest another reviewer if you're unavailable? I rechecked all review feedback against the current head, e23dce755a. The stale Redux entry and stale table-schema cases are covered; the migration uses the database resource endpoint, clears the selection only on 404, and preserves local state on 400/403/500 or network errors. The payload always supplies `dbId` (nullable for `TabState`), while orphaned `TableSchema` entries are not posted with a deleted foreign key. I found no further change needed for those comments. The GitHub run for this exact head contains `PASS src/SqlLab/actions/sqlLab.test.ts` in [Jest shard 4](https://github.com/apache/superset/actions/runs/34835279065/job/103948668076). Both [regular](https://github.com/apache/superset/actions/runs/34835278877/job/103947704391) and [application-prefix](https://github.com/apache/superset/actions/runs/34835278877/job/103947704422) Playwright jobs passed, as did pre-commit and frontend lint. The branch is mergeable; human review is the remaining gate. No new commits were needed for this audit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
