rusackas commented on PR #42849: URL: https://github.com/apache/superset/pull/42849#issuecomment-5763332145
Heads up, the PR title itself doesn't match the required conventional-commit format (that's why lint-check is red) — needs to start with something like `feat(dashboard):`. And lint-frontend's still failing on the same TS error I flagged before, dashboardTimeGrainAllowlist.length possibly undefined on line 122 — looks like the oxfmt commit only reformatted, didn't touch that. Still curious about the useSelector question above and why this needs a separate allowlist mechanism instead of extending the per-filter one; happy to fix the title/lint myself if you'd rather focus on that design question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
