rusackas commented on PR #43184: URL: https://github.com/apache/superset/pull/43184#issuecomment-5763380457
@bikash-barnwal this needs a rebase, it's fallen behind enough that bundle-size is failing on a missing module and pre-commit just needs the new test file reformatted. Rebase should clear both. Also, codeant's thread on `stableRowKey` is still open and looks valid: falling back to just the id field means a non-id value changing on an otherwise-stable row won't flip the signature, so `onFilteredRowsChange` could stay silent when it shouldn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
