gabotorresruiz commented on PR #44437: URL: https://github.com/apache/superset/pull/44437#issuecomment-5767141281
Thanks for the quick turnaround on #44436, @kokhlo, and your diagnosis is exactly right. The catch is that master already carries an equivalent fix: `43fee87672` (#44445, merged 2026-09-19) added a sibling `_restore_context` helper to the same file. Your branch was opened about four hours before that one landed, so this is a scoop rather than a mistake, but the remediation has shipped. I verified it on a clean checkout: at this PR's parent `128c0c1` the six tests fail with `sqlite3.ProgrammingError: Error binding parameter 1: type 'MagicMock' is not supported`, exactly as you described, and at master `322eaeaf99` `test_base_restore_version_command.py` plus `test_restore_version_concurrency.py` give `17 passed`. So I agree with @rebenitez1802 that the right move here is to close this one as superseded. One loose end that outlives both PRs: #44436 is still open, because #44445 never linked it. Worth closing, otherwise the next person who sees a red `unit-tests-required` will read the issue and conclude master is still broken. For the record, since stubbing out a lock read always invites the question: no coverage was lost by either fix. `test_restore_version_concurrency.py` pins the lock directly, and I confirmed by mutation on master that dropping `with_for_update()`, `populate_existing()`, the `uuid` pin or the `deleted_at=None` predicate from `_do_restore` each turns that file red (`3 failed, 2 passed`) while `test_base_restore_version_command.py` stays green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
