mikebridge commented on PR #44262: URL: https://github.com/apache/superset/pull/44262#issuecomment-5767661483
Comment follow-up at `1e2982ea941e126924cb0a5fc9418e4259a69b65`: added direct replies on the three remaining fixed inline findings (scalar boundary entity type, evidence ID-only projection, and scalar boundary UUID isolation). The SQLite version-floor fix is covered in the earlier final-fixes summary: https://github.com/apache/superset/pull/44262#issuecomment-5765672563 . Current-head CI has now completed without failing or pending checks. For completeness, acknowledging Bito's older duplicated-test-setup suggestion: https://github.com/apache/superset/pull/44262#issuecomment-5720512336 . The tests still use separate setup; that cleanup has not been implemented and is not being claimed fixed. The earlier boundary-logic duplication suggestion was already recorded as a structural follow-up: https://github.com/apache/superset/pull/44262#issuecomment-5708834664 . Thanks @aminghadersohi for the latest execution check confirming the UUID gap is closed and the production-change mutants are caught. Human threads are left for their reviewers to resolve; final approval is still outstanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
