fitzee commented on PR #44336: URL: https://github.com/apache/superset/pull/44336#issuecomment-5768229186
Reviewed the latest Bito suggestions. Added the final-retry test's parameter/return annotations and scenario docstring in 142023331a680e356baa992bffb209962b31e999. Four focused cases and all PR pre-commit checks pass. Leaving the remaining suggestions unchanged: - The cancellation counter reset is intentional. The same update clears retry_scheduled_dttm; execution_owner/execution_window remain only as stale-message fences. Removing the reset would preserve stale retry state. - Repeating deterministic window normalization and the equivalent naive-UTC timestamp idioms are small refactoring nits, not correctness gaps. No reason to switch back to deprecated utcnow(). - is_editor_error already has a field comment restricting diagnostic email to schedule editors. The earlier review replies explain the caller restriction and terminal-error fallback. - Extra annotations on inferable test locals and comments on established inline-import patterns do not justify further churn here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
