no-hup commented on PR #43990: URL: https://github.com/apache/superset/pull/43990#issuecomment-5768578683
Good call — added that in e007c6a. It's a companion to the /charts test: materialize the slices (like `schema.dump` does), prefetch, then read editors/viewers per slice and assert no extra SQL. I checked it's load-bearing — drop the `prefetch_chart_access` call and it fails with 6 statements for 3 charts, so it'll catch that call being removed or moved after serialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
