rusackas commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-5768913945
Before this merges, AuroraMySQLDataAPI and AuroraPostgresDataAPI still skip `default_port` in their metadata, and they inherit `build_sqlalchemy_uri` from Postgres/MySQLEngineSpec, which reads `cls.metadata["default_port"]` whenever the port's blank. That'll KeyError on the Data API flavors since they're portless. The IBM i/Arc/Databricks/Kusto notes from sadpandajoe look addressed already. Also, since #43566 covers six of the same files, let's hold this until that one lands and you rebase on top, like you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
