rusackas commented on PR #43693: URL: https://github.com/apache/superset/pull/43693#issuecomment-5769470130
@Archita-kale this had gone quiet for a couple weeks with @sadpandajoe's last two catches still open, so I went ahead and pushed fixes for both in `bf359f7` rather than wait longer: the categorical fill no longer materializes an unobserved `<NULL>` bucket for dimensions with no missing values, and nullable extension dtypes (`Int64`, `Float64`, `boolean`) get cast to object before filling instead of raising. All 44 pivot tests plus the full 153-test `pandas_postprocessing` suite pass, and pre-commit's clean on the changed files. @sadpandajoe want to give this one final look, given you did all the real work catching these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
