rusackas commented on PR #44248: URL: https://github.com/apache/superset/pull/44248#issuecomment-5769770377
Heya @Ujjwaljain16, this looks solid. The fallback logic factored out into `scripts/docker_release_target.py` with its own test coverage is exactly what sadpandajoe's thread was asking for, and CI's green across the board. Only thing standing in the way now is a rebase. GitHub shows conflicts with `master`. If you can rebase, we'll get this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
