Kunal8954 commented on PR #44069: URL: https://github.com/apache/superset/pull/44069#issuecomment-5769811791
Pushed the review-driven fixes. Summary of the three behavior changes: 1. **No more cascade clears on dashboard load.** The reducer re-emits a parent's persisted mask on mount (empty extraFormData first, then its saved clauses). Those synchronization emissions now count as initialization, not as a user change, so a saved parent/child combination loads untouched. 2. **Out-of-scope descendants are staged, then invalidated when their tab returns.** Cascade clears now stage the child on *every* affected descendant (no error `validateStatus`, so Apply isn't blocked one tab away). `getFiltersToApply` already skips out-of-scope filters without a value, so the cleared value only dispatches the moment that tab becomes active — no stale applied selection left behind. 3. **Select reset undoes a pending search-all query.** Clear-all and cascade now share one reset that cancels the pending `onSearch` debounce, resets `ownState.search`, and remounts the Select so stale search text can't re-scope a refetched option list. The visual clear trigger is also scoped to in-scope `filter_select` children only. Tests updated: mount-time persistence is pinned (no child call), tab-return invalidation is pinned (staged null dispatches on the returned tab), the inverse-selection test now exercises a real IN/NOT IN flip, and Select ownState-cancel is covered. `FilterBar` 37/37, `SelectFilterPlugin` 48/48, oxlint + custom-rules clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
