rusackas commented on PR #44392:
URL: https://github.com/apache/superset/pull/44392#issuecomment-5769845636
Heya @geido, nice write-up on this one.
One thing before it can merge, though: CI's failind due to this diff.
`DeleteModal`'s `disablePrimaryButton` now disables the confirmation input too,
and that breaks `DatasetList.integration.test.tsx` ("bulk delete confirm cannot
be submitted before the dependents lookup resolves"). The test types DELETE
while the lookup's pending, expecting the button to enable once it resolves,
but since the input's now disabled during that window, the DELETE never
actually gets typed in, so it stays disabled for good.
`disablePrimaryButton` is used elsewhere too, so this needs a fix rather
than a rerun. The threads from @EnxDev look addressed in the later commits
already.
Say the word if you want a hand tackling any of the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
