rusackas commented on PR #44373: URL: https://github.com/apache/superset/pull/44373#issuecomment-5769844900
Nice writeup on the root cause, and the coalescing approach makes sense for the multi-cursor case. Holding off on this one though since @sadpandajoe's comments are still open. The backspace ordering concern in particular sounds like it could reintroduce a version of the same bug, cursor events landing before the document change flushes, so I'd want that addressed (or explained why it doesn't apply) before this goes in. The test-gap comment seems easy enough to knock out alongside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
