hughhhh commented on PR #43757: URL: https://github.com/apache/superset/pull/43757#issuecomment-5769895320
> Codeant flagged a couple of real issues here. The mapping validation running even when `PARTITION_FILTER_MAPPING`'s off (so disabled deployments could still get save rejections from logic they never opted into), and the partition fields missing from the create allowlist, so a mapping set at create time gets silently dropped. Also still waiting on @sadpandajoe's question about whether the inactive-transform case belongs in the summary the same way. Would love to see all that cleared up before this first PR in the stack merges. Thanks :) yoo @rusackas gonna address these soon boss, i'm just trying to get the branch into a good state after all the upstream changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
