rusackas commented on PR #44456: URL: https://github.com/apache/superset/pull/44456#issuecomment-5770008926
Thanks for chasing this down, solid fix for a real crash. CI's green and the Bito thread already got resolved, but a few Copilot comments are still open (the `userId` truthy check, the redundant `hasUserId` guard, and possible flakiness in the new effect-driven test). Mind addressing those before this merges? Happy to take another pass after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
