seunggabi commented on PR #44499:
URL: https://github.com/apache/superset/pull/44499#issuecomment-5770262773
@rusackas thanks, you're right. `_download_reason()` was unconditional on
the report side, so the URL changed with the flag off. Fixed in 00d60edb8: it's
now `_download_reason_params()` and returns `{}` unless
`REQUIRE_DOWNLOAD_REASON` is on, so the old URL assertions hold as-is and
there's a separate flag-on test for the xlsx case.
Rebased on master too (only UPDATING.md conflicted). CI should be green now,
will keep an eye on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
