bito-code-review[bot] commented on code in PR #44124: URL: https://github.com/apache/superset/pull/44124#discussion_r4068532130
########## Dockerfile: ########## @@ -18,7 +18,7 @@ ###################################################################### # Node stage to deal with static asset construction ###################################################################### -ARG PY_VER=3.11.14-slim-trixie +ARG PY_VER=3.11.16-slim-trixie Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Cache tag not synced</b></div> <div id="fix"> Bumping `ARG PY_VER` to 3.11.16 without updating the `apache/superset-cache:3.11.14-slim-trixie` refs in `docker-compose.yml`, `docker-compose-non-dev.yml`, and `docker-compose-light.yml` fails `tests/unit_tests/scripts/docker_cache_ref_test.py` (its `allowed` regex derives from the Dockerfile default) and leaves those consumers pulling a tag nothing writes, forcing cold builds. Bump the three compose files together. </div> </div> <small><i>Code Review Run #36bf4c</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
