shivaansh0610-LUFFY commented on issue #44079: URL: https://github.com/apache/superset/issues/44079#issuecomment-5773922235
Hey @squalou, I'd like to take a shot at fixing this if it's still open. From a quick look, seems like the string gets to `BigInt()` already in scientific notation (something like `3.21...e+28`), which the constructor just can't parse - it only accepts plain integer literals. So it's failing before it even gets a chance to represent the value properly. Also noticed #44007 looks like the same underlying gap from the other direction - `Math.abs()` choking on an actual BigInt in the cell formatter once a column crosses `MAX_SAFE_INTEGER`. Might be worth treating these as one root cause instead of two separate patches, will take a look at both while I'm in there. Going to dig into the SQL Lab validation path first since that's where it dies without a real error. Can someone assign this to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
