CodeWithPravinMaske commented on PR #44527: URL: https://github.com/apache/superset/pull/44527#issuecomment-5776031840
Thanks for the review, @bito-code-review. Pushed a follow-up commit addressing feedback: - **Fixed** — `parseTimeRange` now rejects a value missing the `" : "` separator instead of silently defaulting the missing end date to "now" (`dayjs(undefined)` is valid). Added a regression test. - **Fixed** — added `filter_date_range` alongside `filter_time` in the Alerts & Reports scheduled-report filter serializer (`superset/reports/models.py`) and in `AlertReportModal.tsx`, so scheduled reports handle this filter the same way they already do Time Range. - **Not applicable** — the "unguarded queriesData destructure" and "dead enableEmptyFilter control" items match the existing `filter_time` plugin's pattern exactly (queriesData is always populated for UI-only filters with no `buildQuery`; `enableEmptyFilter` is consumed by the FilterControl wrapper, not the plugin component). Left as-is for consistency with that precedent. - **Out of scope** — the rison/URL deep-linking gap in `risonFilters.ts` (`convertRisonToNativeValue`) is a pre-existing issue that also affects `filter_time` today (its case there uses the wrong string, `filter_time_range` instead of `filter_time`, so it's dead code already). Fixing it properly means touching shared rison-injection logic used by every filter type — happy to file that separately rather than scope-creep this PR. - **Left as-is** — the unused `defaultValue` field mirrors the identical dead field already present in `Time/types.ts`; keeping it for consistency with that plugin's structure rather than diverging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
