bito-code-review[bot] commented on code in PR #44529:
URL: https://github.com/apache/superset/pull/44529#discussion_r4073084831
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -18,10 +18,12 @@
*/
import { SyntheticEvent } from 'react';
import domToImage from 'dom-to-image-more';
+import html2canvas from 'html2canvas';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Heavy lib in core bundle</b></div>
<div id="fix">
Static `import html2canvas` pulls a ~200KB library into the core bundle even
though it is only used on Safari. The same file deliberately lazy-loads echarts
(line 49 comment, line 621) to keep heavy deps out of the core bundle;
html2canvas should follow that pattern with a dynamic import inside the
`isSafari()` branch.
</div>
</div>
<small><i>Code Review Run #8e8591</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
