villebro commented on PR #44508: URL: https://github.com/apache/superset/pull/44508#issuecomment-5778970011
@rusackas — confirming 842d2f1 was the right fix: `string_clip_chars` addressed the actual structural bug (a fixed 500-char clip could exceed a small `max_bytes`, so truncation could never converge under a tight budget), and `UNMEASURABLE_RESPONSE_BYTES` is the correct replacement for the old fixed 1MB fallback now that `max_bytes` is operator-configurable up into that range. Nothing to push back on there — thanks for catching and fixing it directly. One follow-up on top, in b950a5fbe5: the Bito review that ran against your commit flagged 3 secondary suggestions (a duplicate test, an unnamed magic-number divisor, and a `>=` that should be `==` against the sentinel) — folded/fixed all three. Also caught a couple of "100 KB" mentions left in docstrings by your commit, now stale since the default changed in the meantime. Nothing structural, just cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
