deepujain commented on PR #44507: URL: https://github.com/apache/superset/pull/44507#issuecomment-5779724379
Regarding [the BigInt precision suggestion](https://github.com/apache/superset/pull/44507#issuecomment-5769271524): the rounding observation is correct. This formatter intentionally produces an approximate, unit-scaled display through the existing Number-based formatting path; it is not an exact integer serializer. The PR description now states that limitation explicitly. The focused regression preserves the requested binary display (`1.24EiB`) for the reported BigInt input and the existing number cases. Exact arbitrary-precision byte formatting would require a separate precision contract and is outside this crash fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
