hughhhh commented on PR #44534:
URL: https://github.com/apache/superset/pull/44534#issuecomment-5780024529

   This is blocking unrelated PRs — 
`tests/unit_tests/scripts/docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver`
 fails on `master` for both consumers, so every branch cut from it inherits two 
red `unit-tests` failures (and therefore a red `unit-tests-required` gate). Hit 
it on #43757, where the diff touches none of these files.
   
   Reproduced on a clean `origin/master` checkout — `Dockerfile`, both 
workflows and the test file are byte-identical to `master`:
   
   ```
   Dockerfile ARG PY_VER = 3.11-slim-trixie
   
   ok    docker-compose.yml                                   
refs=['3.11-slim-trixie']
   ok    docker-compose-non-dev.yml                           
refs=['3.11-slim-trixie']
   ok    docker-compose-light.yml                             
refs=['3.11-slim-trixie']
   FAIL  .github/workflows/superset-frontend.yml              
refs=['3.11.14-slim-trixie']
   FAIL  .github/workflows/frontend-bundle-size-nightly.yml   
refs=['3.11.14-slim-trixie']
   ```
   
   The direction here looks right: `scripts/docker-build-extra-flags.sh:68` 
exports `apache/superset-cache:${DEFAULT_PY_VER}`, sourced from the Dockerfile 
at `:44`, so `3.11-slim-trixie` is the tag anything actually writes — the two 
workflows were pulling one nothing publishes, which means they were getting 
cold builds too, not just a red test.
   
   Any blocker to taking this out of draft?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to