sadpandajoe opened a new pull request, #44537: URL: https://github.com/apache/superset/pull/44537
### SUMMARY Removes the old Cypress dashboard drill-to-detail suite (`cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts`) and its dedicated helpers. The whole suite was wrapped in `describe.skip` (disabled due to Cypress-specific autoscroll/sticky-header flakiness) and contributed zero live coverage. It is fully superseded by the Playwright suite at `superset-frontend/playwright/tests/dashboard/dashboard-drill-to-detail.spec.ts`, which covers the same drill-to-detail flows with a more robust approach: canvas (echarts) drills scan a stable region of the canvas for the datum under the cursor instead of relying on hardcoded pixel coordinates, so they aren't tied to exact chart geometry. Also removed: - `shared_dashboard_functions.ts` and `dashboard/utils.ts` — helpers used only by the deleted suite. - `support/directories.ts` — became fully orphaned once `dashboard/utils.ts` was removed (confirmed via repo-wide grep). - Two dashboard URL constants (`SAMPLE_DASHBOARD_1`, `SUPPORTED_CHARTS_DASHBOARD`) only referenced by the deleted files. One export from `dashboard/utils.ts` (`interceptGet`) was still used by the live `explore/chart.test.js` suite, so it was inlined into `explore/utils.ts` as `interceptDashboardGet` rather than deleted, and both call sites updated. `createSampleDashboards`/`dashboards.json` were kept as-is since `chart.test.js`'s "Cross-referenced dashboards" suite still exercises them. Also fixes a stale example command in `docs/developer_docs/contributing/howtos.md` that referenced a Cypress spec file that no longer exists. **Coverage note:** the Playwright suite intentionally excludes Bar, Area, World Map, and Radar chart drills, matching the original Cypress suite's own nested `describe.skip`s on those same four chart types — no regression, since those were already not running. ### TESTING INSTRUCTIONS - `npm run type` and `pre-commit run` pass on the changed files. - The Playwright replacement (`dashboard-drill-to-detail.spec.ts`) already exists on `master` and covers the migrated flows; run it via `npx playwright test tests/dashboard/dashboard-drill-to-detail.spec.ts`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
