rusackas opened a new pull request, #44540:
URL: https://github.com/apache/superset/pull/44540

   ### SUMMARY
   Found while chasing an intermittent `sharded-jest-tests` failure on an 
unrelated PR: `CsrfErrorMessage.test.tsx`'s compact-mode test calls 
`userEvent.click(...)` without `await`, letting the assertion right after it 
race the click's own React state update. Every other `userEvent.click` call in 
`src/components/ErrorMessage/` 
(Database/ErrorMessageWithStackTrace/FrontendNetworkError/ParameterError/TimeoutError)
 awaits it; this was the only one that didn't.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A, test-only change.
   
   ### TESTING INSTRUCTIONS
   
   ```
   cd superset-frontend
   npx jest src/components/ErrorMessage/CsrfErrorMessage.test.tsx
   ```
   All 3 tests pass.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to