aminghadersohi commented on PR #44152: URL: https://github.com/apache/superset/pull/44152#issuecomment-5784195889
Re-verified Bito’s 2026-09-11 “Uncaught pydantic ValidationError” finding at current head 5e0dcf94110bf363ebebd526842a038fcb23cf8d: no code change is needed. The review-body link points to discussion_r3989638526, which is already resolved (including the prior explanation in discussion_r3989838698). Pydantic ValidationError inherits ValueError, so update_chart_preview.py’s existing except ValueError handler returns the structured ValidationError response. Existing regression evidence at this head: tests/unit_tests/mcp_service/chart/test_treemap_completeness.py::test_resolution_validation_error_is_caught_value_error constructs a genuine failing Treemap resolution and asserts that inheritance. The same suite exercises registered update_chart_preview calls with missing cached roles, asserting success=false, error_type=ValidationError, no transport error, and no cache write. Fresh verification: PYTHONPATH="$PWD/superset-core/src:$PWD" python -m pytest tests/unit_tests/mcp_service/chart/test_treemap_completeness.py tests/unit_tests/mcp_service/chart/tool/test_update_chart_preview.py -q --disable-warnings → 177 passed, 2 skipped, 0 failed. Ruff check on those two test files and update_chart_preview.py → all checks passed. The initial test invocation without the local superset-core source path failed during conftest import; the corrected invocation above completed successfully. No files changed, no commit or push, and no review-state changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
