aminghadersohi commented on PR #44504: URL: https://github.com/apache/superset/pull/44504#issuecomment-5784197969
Re-verified the security-to-views review suggestion against the live approved head `796a70b352db0bddda360b164a90e16293b5f798`. This was a real import-time failure, already fixed by **b7be7b44df681f1ab84dea4c2431c5ceb4977e69**, which is an ancestor of the current head. The linked inline thread is already resolved. Independent evidence from fresh Python processes (with `PYTHONPATH="$PWD:$PWD/superset-core/src"`): - `import superset.security.password_change` succeeds; `"superset.views" in sys.modules` is `False`. - Moving the health import back to module scope in an in-memory copy of the current source (without modifying repository files) reproduces `Exception: App not initialized yet. Please call init_app first` through `views` → `models.core` → `encrypted_field_factory.create`. Validation at the current head: `pytest -q tests/unit_tests/security/ tests/unit_tests/views/test_health.py tests/unit_tests/initialization_test.py` — **434 passed, 0 failed** (30.06s). `ruff check superset/security/password_change.py tests/unit_tests/security/test_password_change.py` — passed. No additional code change or commit is needed for the already-fixed suggestion; no new regression test was added in this verification pass. No review re-request or approval dismissal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
