sadpandajoe commented on code in PR #43903:
URL: https://github.com/apache/superset/pull/43903#discussion_r4076733225
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -472,6 +472,69 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False
The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`)
to determine which hosts are internal.
+## Retry on Failure
+
+This feature is gated behind the `ALERT_REPORTS_RETRY` feature flag, which is
+disabled by default:
+
+```python
+FEATURE_FLAGS = {
+ "ALERT_REPORTS_RETRY": True,
+}
+```
+
+With the flag enabled, reports (not alerts) can be configured to
+automatically retry when sending fails — this covers rendering/export
+failures (e.g. a chart screenshot or CSV export erroring out) as well as
+delivery failures such as a transient SMTP or Slack error — instead of
+moving straight to an `Error` state. Execution timeouts (the Celery soft
Review Comment:
The soft-limit and execution-budget exclusions are not unconditional:
`ReportSuccessState` catches them in its broad handler and invokes the retry
path. A report whose previous run succeeded can therefore enter `Retrying`
after either timeout instead of going straight to `Error`. Could this qualify
the exclusion (or make those paths terminal consistently)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
