rusackas commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-5787193651
@eugeneo17 CI's red here on three things, none of them your code: `babel-extract`/pot drift, a Docker cache-ref tag mismatch, and a flaky CSRF test, all already fixed on `master` (#44509, #44534, #44540) since this branch last synced. I rebased it locally to pick all three up plus a fresh `babel_update.sh` run (one more string got reworded on `master` in the meantime), and everything resolved cleanly except a real conflict in the soft-delete-restore tests another PR landed in the same file — merged both sets of tests in, nothing dropped. I can't push it though, "Allow edits by maintainers" isn't enabled on this fork (and it's org-owned, so I can't fork-push either). Pushed the rebased branch to mine as a reference: https://github.com/rusackas/superset/tree/rebase-43303-for-eugeneo17 — feel free to pull from it, or just rebase onto current `master` and rerun `./scripts/translations/babel_update.sh` yourself, whichever's easier. Otherwise happy to enable maintainer edits your side and I'll push it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
